Ticket #20 (closed defect: fixed)

Opened 2 months ago

Last modified 7 weeks ago

arbiter.get_sharing_mode() is ambiguous

Reported by: bmayton Owned by: plunkett
Priority: minor Milestone: 2.0 Release
Component: Arbiter Version:
Keywords: Cc:

Description

The name of the function "get_sharing_mode" is not conducive to readable code. Didn't this used to be called "is_instructor" or something similar?

The following:

if self.__arbiter.get_is_instructor():
   blah

is a lot more clear than:

if self.__arbiter.get_sharing_mode():
   blah

The second (which is the current implementation) doesn't allow the reader to infer that it returns a boolean, and what the values of True or False imply. The first makes both of these clear.

Attachments

Change History

Changed 2 months ago by bmayton

  • component changed from ClassroomPresenter to Arbiter

Changed 7 weeks ago by plunkett

  • status changed from new to closed
  • resolution set to fixed

I agree. Made changes per Brian's advice in the description of this ticket.

Changeset 107

Add/Change #20 (arbiter.get_sharing_mode() is ambiguous)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.